fix(hud): keep the "End session" confirm popover on-screen (#97) #101

Merged

albert merged 2 commits from u/albert/97/hud-popover-clipped into main 2026-07-19 06:15:01 +00:00

Conversation 0 Commits 2 Files changed 10 +162 -34

albert commented 2026-07-19 06:07:00 +00:00

Owner

Copy link

The prompt is a Popover parented to the action button, the rightmost
widget of the right-aligned HUD bar. With no explicit placement GTK
centered it horizontally on the button, pushing half of it past the
right screen edge; under gtk4-layer-shell + sway an oversized popup is
not slid back on-screen, so it clipped. The XWayland HiDPI counter-scale
enlarges the popover, making the overflow bigger and the bug more
visible (hence "occasionally").

Give the popover PositionType::Bottom (a top bar has unlimited room
below) and, at popup() time, right-align it to the button by shifting
its center left by (popover_width - button_width)/2 — landing its right
edge on the button's right edge, fully on-screen, without relying on any
compositor slide-to-fit. Width is measured from the content Box (a
GtkPopover reports ~0 before it is mapped) plus the scale-aware chrome.

Reproduced and verified headlessly at HiDPI factor 1.5 and the normal
factor 1.0; see docs/ai/history/2026-07-19 001.

Also documents the headless harness's dev-click limitation in the
headless-dev skill, and notes a preference for in-repo docs over private
agent memory in AGENTS.md.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01S4naZNwEpnVCF71D1Huhe4

Fixes #97

The prompt is a Popover parented to the action button, the rightmost widget of the right-aligned HUD bar. With no explicit placement GTK centered it horizontally on the button, pushing half of it past the right screen edge; under gtk4-layer-shell + sway an oversized popup is not slid back on-screen, so it clipped. The XWayland HiDPI counter-scale enlarges the popover, making the overflow bigger and the bug more visible (hence "occasionally"). Give the popover PositionType::Bottom (a top bar has unlimited room below) and, at popup() time, right-align it to the button by shifting its center left by (popover_width - button_width)/2 — landing its right edge on the button's right edge, fully on-screen, without relying on any compositor slide-to-fit. Width is measured from the content Box (a GtkPopover reports ~0 before it is mapped) plus the scale-aware chrome. Reproduced and verified headlessly at HiDPI factor 1.5 and the normal factor 1.0; see docs/ai/history/2026-07-19 001. Also documents the headless harness's dev-click limitation in the headless-dev skill, and notes a preference for in-repo docs over private agent memory in AGENTS.md. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S4naZNwEpnVCF71D1Huhe4 Fixes #97

albert added 1 commit 2026-07-19 06:07:00 +00:00

fix(hud): keep the "End session" confirm popover on-screen (#97) ... 884bf47bd8

The prompt is a Popover parented to the action button, the rightmost
widget of the right-aligned HUD bar. With no explicit placement GTK
centered it horizontally on the button, pushing half of it past the
right screen edge; under gtk4-layer-shell + sway an oversized popup is
not slid back on-screen, so it clipped. The XWayland HiDPI counter-scale
enlarges the popover, making the overflow bigger and the bug more
visible (hence "occasionally").

Give the popover PositionType::Bottom (a top bar has unlimited room
below) and, at popup() time, right-align it to the button by shifting
its center left by (popover_width - button_width)/2 — landing its right
edge on the button's right edge, fully on-screen, without relying on any
compositor slide-to-fit. Width is measured from the content Box (a
GtkPopover reports ~0 before it is mapped) plus the scale-aware chrome.

Reproduced and verified headlessly at HiDPI factor 1.5 and the normal
factor 1.0; see docs/ai/history/2026-07-19 001.

Also documents the headless harness's dev-click limitation in the
headless-dev skill, and notes a preference for in-repo docs over private
agent memory in AGENTS.md.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S4naZNwEpnVCF71D1Huhe4

albert added 1 commit 2026-07-19 06:14:16 +00:00

chore: bump version to 0.2.1 ... ef73e7c3cc

Written across VERSION, Cargo.toml/Cargo.lock, and the webui package
manifests via `shepherd version set 0.2.1`; `shepherd version check`
passes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01S4naZNwEpnVCF71D1Huhe4

albert merged commit a377fd01b4 into main 2026-07-19 06:15:01 +00:00

albert referenced this pull request from a commit 2026-07-19 06:15:03 +00:00

Merge pull request 'fix(hud): keep the "End session" confirm popover on-screen (#97)' (#101) from u/albert/97/hud-popover-clipped into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

future

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

future

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

albert/shepherd-launcher!101

No description provided.